Skip to content

feat: upgrade resource and did modules to v0.50.x [DEV-4979] #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 62 commits into from
May 14, 2025

Conversation

PrathyushaLakkireddy
Copy link
Collaborator

No description provided.

@PrathyushaLakkireddy PrathyushaLakkireddy changed the title WIP: upgrade resource module to v0.50.x WIP: upgrade resource and did modules to v0.50.x Apr 17, 2025
@Eengineer1
Copy link
Contributor

Let's focus on resolving the build errors, before moving on with unit, integration + upgrade tests in that order.

@tweeddalex tweeddalex changed the title feat: WIP - upgrade resource and did modules to v0.50.x feat: WIP - upgrade resource and did modules to v0.50.x [DEV-4979] May 6, 2025
@ankurdotb
Copy link
Contributor

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar note here; ICQ should be included since it's part of v3 minor upgrades.

Copy link
Collaborator

@akhilkumarpilli akhilkumarpilli May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ICQ was not included in minor upgrades too. Missed including icq in module manager in previous versions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing.

Could you ensure ICQ is added to the upgrade store inserted modules within this upgrade? (Usually in app.go, along with other modules).

@akhilkumarpilli akhilkumarpilli changed the title feat: WIP - upgrade resource and did modules to v0.50.x [DEV-4979] feat!: upgrade resource and did modules to v0.50.x [DEV-4979] May 12, 2025
@akhilkumarpilli akhilkumarpilli marked this pull request as ready for review May 12, 2025 11:50
Copy link
Contributor

@Eengineer1 Eengineer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Final sign-off approved 👍.

@Eengineer1 Eengineer1 changed the title feat!: upgrade resource and did modules to v0.50.x [DEV-4979] feat: upgrade resource and did modules to v0.50.x [DEV-4979] May 14, 2025
@Eengineer1 Eengineer1 merged commit 96b8367 into akhil/v0.50_bump May 14, 2025
18 checks passed
@Eengineer1 Eengineer1 deleted the prathyusha/upgrade_resource branch May 14, 2025 13:57
Eengineer1 added a commit that referenced this pull request May 14, 2025
* WIP: deps!: bump sdk to v50

* WIP: update few changes in app.go

* WIP: fixed app package changes and working on cmd

* WIP: fix few more issues

* fix remaining issues and add upgrade handler

* fix typo

* update test_helper

* fix icq issue

* update go version

* Tidy dependencies

* update golangci-lint and math version

* fix errors

* feat: upgrade resource and did modules to v0.50.x [DEV-4979] (#876)

* wip: upgrade resource module

* fix typo

* fix

* update test setup

* change types

* wip

* add migrations

* remove validate basic

* fix

* fix test setup

* fix

* feat!: upgrade did module to v0.50.x (#878)

* wip

* wip

* wip

* wip

* feat(params): add migrator support to did module

* feat: add autocli support

* wip

* fix

* wip

* chore: remove comment

* chore: add migrate

* chore: add migration in module.go

* feat: add SetParams function

* go.mod

* fix

* setconfig

* fix proto annotations

* feat: change functions

* chore: fix param_change_proposal tests

* chore: remove comment

* fix keeper tests

* feat: implement customgetsigner

* wip

* chore: added query params func and updated the params key

* add custom signers

* fix key

* fix

* chore: add params to autocli

* add params

* fix autocli

* fix typo

* fix

* fix

* fix lint and errors

* update golangci lint version in gha

* fix tests setup

* fix almost failing unit tests

* fix lint and other changes

* revert integration test changes

* WIP: fee abs tests fix

* add resource params query and fix fee abs test

* fix few integration tests and update swagger

* fixed insufficient funds test issue

* WIP: fix query proposal test and address comments

* fix faiing integration test

* fix unit test

* WIP: setup v4 upgrade tests

* fix upgrade migrations issues

* fix post upgrade tests and wip integration tests after upgrade

* fix pre test

* fix post tests

* fix all tests

* fix lint

---------

Co-authored-by: Vishal Potpelliwar <[email protected]>
Co-authored-by: vishal <[email protected]>
Co-authored-by: akhilkumarpilli <[email protected]>
Co-authored-by: Tasos Derisiotis <[email protected]>

---------

Co-authored-by: Tasos Derisiotis <[email protected]>
Co-authored-by: Prathyusha Lakkireddy <[email protected]>
Co-authored-by: Vishal Potpelliwar <[email protected]>
Co-authored-by: vishal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants